[Gecko Bug 1032124] Use the referenced element to check whether to ignore a mutation event #17330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `nsContentUtils::IsInSameAnonymousTree(this, aElement)` to check will ignore all mutation notification for anonymous <use> which will happen when <use> is nested. This is the cause that second-level <use> isn't properly synced with element mutation. We should use the referenced element instead of `this` in the check condition. Differential Revision: https://phabricator.services.mozilla.com/D34284 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1032124 gecko-commit: 96b0fd9c79cd30dfe59597a8a77564862eb30091 gecko-integration-branch: autoland gecko-reviewers: emilio, longsonr
wpt-pr-bot
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
nsContentUtils::IsInSameAnonymousTree(this, aElement)to check will ignore all mutation notification for anonymous which will happen when is nested. This is the cause that second-level isn't properly synced with element mutation.We should use the referenced element instead of
thisin the check condition.Differential Revision: https://phabricator.services.mozilla.com/D34284
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1032124
gecko-commit: 96b0fd9c79cd30dfe59597a8a77564862eb30091
gecko-integration-branch: autoland
gecko-reviewers: emilio, longsonr