Have containValues check array lengths #17327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1659492
branch
2 times, most recently
from
ef2e243
to
60d07ef
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1659492
branch
2 times, most recently
from
0e883d7
to
78e68eb
Compare
If the number of distinct elements in the input array does not match the number of elements in the expected set, an error was thrown trying to read a property from undefined. Instead, check that the lengths match and if they don't fail the test with an appropriate message. Also remove the-convolvernode-interface/active-processing.https.html that should have been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1653924 but wasn't. Bug: 974022, 978372 Test: audit-failures.html Change-Id: Ifa2da978f3c0f67dc444c69ceddb862675908b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659492 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#677080}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1659492
branch
from
78e68eb
to
81727ad
Compare
|
Modifying the support file affects a lot of tests which include some pre-existing flaky ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the number of distinct elements in the input array does not match
the number of elements in the expected set, an error was thrown trying
to read a property from undefined.
Instead, check that the lengths match and if they don't fail the test
with an appropriate message.
Also remove the-convolvernode-interface/active-processing.https.html
that should have been removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1653924 but
wasn't.
Bug: 974022, 978372
Test: audit-failures.html
Change-Id: Ifa2da978f3c0f67dc444c69ceddb862675908b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659492
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677080}