Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macse: init at 2.03 #63117

Merged
merged 1 commit into from Sep 27, 2019
Merged

macse: init at 2.03 #63117

merged 1 commit into from Sep 27, 2019

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Jun 14, 2019

Motivation for this change

Bioinformatic tool used in my laboratory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build macse

@mmahut
Copy link
Member

mmahut commented Sep 5, 2019

@GrahamcOfBorg build macse

pkgs/applications/science/biology/macse/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/macse/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/macse/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/macse/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/macse/default.nix Outdated Show resolved Hide resolved
nativeBuildInputs = [ makeWrapper ];

dontBuild = true;
donUnpack = true; # not working?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reference to dontUnpack in the nixpkgs manual.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's not documented yet I think, but present in many packages and only working in the unstable branch (see #65434). Furthermore, I did a typo! Well I remove this line... Thanks!

pkgs/applications/science/biology/macse/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build macse

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bzizou!

@aanderse aanderse merged commit af5176b into NixOS:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants