Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages: fix + add multinomials 1.3 + coqeal 1.0.0 #63102

Closed
wants to merge 1 commit into from
Closed

coqPackages: fix + add multinomials 1.3 + coqeal 1.0.0 #63102

wants to merge 1 commit into from

Conversation

CohenCyril
Copy link
Contributor

@CohenCyril CohenCyril commented Jun 13, 2019 •
edited

Motivation for this change

Adding latest releases of multinomials and coqeal + fixing mathcomp extra packages (i.e. reducing the number of dependencies by taking into account arguments that used to be ignored and fixing the naming policy)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor Author

Duplicate of #62718

@CohenCyril CohenCyril closed this Jun 13, 2019
@CohenCyril CohenCyril deleted the coqeal branch June 13, 2019 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@CohenCyril