Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop unmaintained phabricator package, service, and httpd subservice #63100

Merged
merged 5 commits into from Jun 15, 2019
Merged

drop unmaintained phabricator package, service, and httpd subservice #63100

merged 5 commits into from Jun 15, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jun 13, 2019 •
edited

Motivation for this change

Stuck on a version from 2014, time for someone to either take this on or drop it.

If everyone agrees this should be dropped then I'll add release notes before we merge.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from infinisil as a code owner June 13, 2019 21:21
thoughtpolice
thoughtpolice approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good to me (while I didn't maintain these packages, I did maintain the Arcanist packages). In general we probably shouldn't be running/"endorsing" obsolete Phabricator versions at all.

danbst
danbst approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@danbst danbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. Maybe mention also in release notes?

I was using an approach based on @thoughtpolice scripts: https://gist.github.com/danbst/0580293476b963755e359e0aa7e9eac5

@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

Please add the release notes.

@aanderse
Copy link
Member Author

If everyone agrees this should be dropped then I'll add release notes before we merge.

I will assume everyone agrees this should be merged then. Will do. Thanks.

@aanderse
Copy link
Member Author

@danbst Thanks for the link!

@FRidh FRidh merged commit 395da12 into NixOS:master Jun 15, 2019
@aanderse aanderse deleted the phabricator-remove branch June 15, 2019 11:15
@aanderse
Copy link
Member Author

Thanks all!

This was referenced Jun 30, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@danbst danbst danbst approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @FRidh @thoughtpolice @danbst