Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: fix nix-hacks.patch with the latest version of Bazel #63052

Merged
merged 2 commits into from Jun 13, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jun 13, 2019

Motivation for this change

The build is failing if enableNixHacks = true;.

NOTE: This PR should be squashed when merging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member Author

@Profpatsch I'm not too fond of the way I wrote the tests for the version with nix hacks, so please let me know if you have suggestions.

I have an overlay on my system that enables it, so thanks to this failure, I can now track it down and get rid of it. Does anyone know what are these hacks for?

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build bazel bazel.tests

Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s fine for now, we can refactor it when we add more tests.

@Profpatsch Profpatsch merged commit bad7bc4 into NixOS:master Jun 13, 2019
@kalbasit kalbasit deleted the nixpkgs_fix-bazel-nix-hacks branch June 13, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants