Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.geary: add libunity #63161

Merged
merged 1 commit into from Jun 15, 2019
Merged

gnome3.geary: add libunity #63161

merged 1 commit into from Jun 15, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 15, 2019

Motivation for this change

Adds unread mail counter to dash to dock:

image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
gnome3.geary: add libunity
0131424 
Adds unread mail counter to dash to dock.
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 15, 2019
@ofborg ofborg bot requested review from worldofpeace and hedning June 15, 2019 15:03
@jtojnar jtojnar merged commit 2ba0d81 into NixOS:master Jun 15, 2019
@jtojnar jtojnar deleted the geary-libunity branch June 15, 2019 16:15
@worldofpeace
Copy link
Contributor

Can't wait until the badges and progress support in libunity is rewrote into a not abandoned library 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @worldofpeace