Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oclgrind: init at 18.3. #63159

Merged
merged 2 commits into from Aug 1, 2019
Merged

oclgrind: init at 18.3. #63159

merged 2 commits into from Aug 1, 2019

Conversation

athas
Copy link
Contributor

@athas athas commented Jun 15, 2019

Motivation for this change

Oclgrind is an indispensable Valgrind-like tool for OpenCL programming.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@athas
Copy link
Contributor Author

athas commented Jun 25, 2019

Is anything missing here?

srhb
srhb approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit about the inputs: I think at least cmake should go in nativeBuildInputs (and I'm not sure about llvm?) though this is only really relevant for cross-compilation, so LGTM.

@athas
Copy link
Contributor Author

athas commented Jul 14, 2019

I have moved cmake to nativeBuildInputs and rebased on top of master.

@veprbl
Copy link
Member

veprbl commented Aug 1, 2019

@GrahamcOfBorg build oclgrind

@srhb srhb merged commit 7d5f527 into NixOS:master Aug 1, 2019
@athas athas deleted the oclgrind branch August 1, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@athas @veprbl @srhb