Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shaarli-material: Mark as broken #63121

Merged
merged 1 commit into from Jan 16, 2020

Conversation

schneefux
Copy link
Contributor

Motivation for this change

shaarli-material is a theme plugin for the shaarli web application.
The version of the theme needs to match shaarli's or else there are server errors, broken scripts and broken styling. shaarli-material is behind by almost a year, so the two versions of shaarli + shaarli-material in the nix store do not work together.
The build process for shaarli-material has changed in 0.10.3 and now depends on npm packages and a gulp script (changelog: https://github.com/kalvn/Shaarli-Material/releases) and I do not know how to update the build recipe for it.
I have not managed to set up a working shaarli + shaarli-material configuration with the prebuilt assets from the GitHub releases page either.

So I'd like to drop the package because it has been unusable for a year, is too difficult to maintain and apparently not used by anyone.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

references need to be removed as well

@schneefux
Copy link
Contributor Author

references removed :)

@gazally
Copy link
Contributor

gazally commented Jul 4, 2019

Why not just mark it as broken?

@schneefux
Copy link
Contributor Author

I've marked it as broken instead.

@angristan You have updated this package in #66201. Are you using it or have you tested it?

@angristan
Copy link
Member

Hi! I am not using it anymore.

@worldofpeace
Copy link
Contributor

I can look into integrating this tomorrow then 👍

@infinisil
Copy link
Member

What's the status on this?

@worldofpeace
Copy link
Contributor

What's the status on this?

@worldofpeace lost this PR in the giant list.
I still guess its fine to merge, will check.

@worldofpeace worldofpeace changed the title shaarli-material: remove shaarli-material: Mark as broken Jan 16, 2020
@worldofpeace worldofpeace merged commit f25df34 into NixOS:master Jan 16, 2020
@schneefux schneefux deleted the pkg/remove-shaarli-material branch January 16, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants