Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsolata-nerdfont: init at 2.0.0 #63079

Merged
merged 1 commit into from Mar 26, 2020
Merged

inconsolata-nerdfont: init at 2.0.0 #63079

merged 1 commit into from Mar 26, 2020

Conversation

dmvianna
Copy link
Contributor

Motivation for this change

nerdfonts-2.0.0 is a 2GB download. Each of these is < 10 MB download. It makes sense to provide separate packages for each font. This prevents issues such as described in #47921.

Things done

I build both, installed on my system and checked their presence with font-manager.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FlorianFranzen
Copy link
Contributor

I agree that installing all of them at once is not always what you want, but I think for this to be merged a more general solution with an auto-update script that creates derivation for all available fonts will be needed.

@jtanguy
Copy link

jtanguy commented Oct 28, 2019

I have this same problem and I am trying to do the method you described.
I have pushed my work in https://github.com/jtanguy/nixpkgs/tree/nerdfonts, but I am not sure how I should test it before making any PR.

Could somebody help me on this ?

@ryantm
Copy link
Member

ryantm commented Jan 4, 2020

@jtanguy What are you trying to test about it?

@mmlb
Copy link
Contributor

mmlb commented Mar 26, 2020 •
edited

@jtanguy maybe just go ahead with the PR? I'd add a passthru.updateScript = ./update.sh; but lets get that feedback in a PR.

@ryantm
Copy link
Member

ryantm commented Mar 26, 2020

Okay, let's merge it then make it better.

@ryantm ryantm merged commit c09f2cc into NixOS:master Mar 26, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 27, 2020
@ryantm @dtzWill
Merge pull request NixOS#63079 from dmvianna/inconsolata-nerdfont-2.0.0
a8bc62a 
inconsolata-nerdfont: init at 2.0.0
(cherry picked from commit c09f2cc)
@jtojnar jtojnar mentioned this pull request Apr 5, 2020
Closed
@doronbehar doronbehar mentioned this pull request Apr 9, 2020
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmvianna @FlorianFranzen @jtanguy @ryantm @mmlb