Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces/longtasks.idl #17305

Conversation

autofoolip
Copy link
Contributor

This PR was automatically created by a bot.

Before merging, please check that any tests that depend on the updated IDL files still work.

If additional changes are needed, please manually create another PR based on this one.

See the README for how the IDL files in this directory are used.


Source: https://github.com/tidoust/reffy-reports/blob/087652c/whatwg/idl/longtasks.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/545077302

@foolip
Copy link
Member

foolip commented Jun 13, 2019

Need to look into "FAIL message: Type DOMHighResTimeStamp not found" before this is merged...

foolip added a commit that referenced this pull request Jun 14, 2019
Because the setup function is allowed to fail, this makes the setup a
bit simpler.

This is to make it easier to add 'hr-time' as a dependency for
#17305.
@foolip
Copy link
Member

foolip commented Jun 14, 2019

Blocked on #17344.

foolip added a commit that referenced this pull request Jun 17, 2019
Because the setup function is allowed to fail, this makes the setup a
bit simpler.

This is to make it easier to add 'hr-time' as a dependency for
#17305.
@foolip foolip assigned lukebjerring and unassigned foolip Jun 17, 2019
@foolip
Copy link
Member

foolip commented Jun 17, 2019

Rebased, but the error remains, seems like there's a problem with idl_test that needs to be resolved. In short, adding 'hr-time' as a dependency isn't enough, the typedef double DOMHighResTimeStamp isn't picked up. Including 'hr-time' as a source fixes this, but that's not right, and it needs even more dependencies to make it work.

@lukebjerring I think the problem is that add_dependency_idls doesn't do anything with typedefs. Unconditionally including them would probably be fine, since they don't do anything unless used. I've taken a look at add_dependency_idls but can't quickly see where this should fit, can you take a look?

marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
Because the setup function is allowed to fail, this makes the setup a
bit simpler.

This is to make it easier to add 'hr-time' as a dependency for
#17305.
@autofoolip autofoolip closed this Jul 24, 2019
@autofoolip autofoolip deleted the reffy-reports/longtasks branch July 24, 2019 06:12
@lukebjerring
Copy link
Contributor

Typedef issue attacked here:
#18006

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 24, 2019
…o use `idl_test`, a=testonly

Automatic update from web-platform-tests
Convert Long Tasks API idlharness test to use `idl_test` (#17344)

Because the setup function is allowed to fail, this makes the setup a
bit simpler.

This is to make it easier to add 'hr-time' as a dependency for
web-platform-tests/wpt#17305.
--

wpt-commits: e5167a1ffdd432f1fadd721d63fd1cf42bd67e96
wpt-pr: 17344
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jul 25, 2019
…o use `idl_test`, a=testonly

Automatic update from web-platform-tests
Convert Long Tasks API idlharness test to use `idl_test` (#17344)

Because the setup function is allowed to fail, this makes the setup a
bit simpler.

This is to make it easier to add 'hr-time' as a dependency for
web-platform-tests/wpt#17305.
--

wpt-commits: e5167a1ffdd432f1fadd721d63fd1cf42bd67e96
wpt-pr: 17344
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…o use `idl_test`, a=testonly

Automatic update from web-platform-tests
Convert Long Tasks API idlharness test to use `idl_test` (#17344)

Because the setup function is allowed to fail, this makes the setup a
bit simpler.

This is to make it easier to add 'hr-time' as a dependency for
web-platform-tests/wpt#17305.
--

wpt-commits: e5167a1ffdd432f1fadd721d63fd1cf42bd67e96
wpt-pr: 17344

UltraBlame original commit: 01d1c2ce6afc75b6c71aead2fb813f25adb1ba87
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…o use `idl_test`, a=testonly

Automatic update from web-platform-tests
Convert Long Tasks API idlharness test to use `idl_test` (#17344)

Because the setup function is allowed to fail, this makes the setup a
bit simpler.

This is to make it easier to add 'hr-time' as a dependency for
web-platform-tests/wpt#17305.
--

wpt-commits: e5167a1ffdd432f1fadd721d63fd1cf42bd67e96
wpt-pr: 17344

UltraBlame original commit: 01d1c2ce6afc75b6c71aead2fb813f25adb1ba87
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…o use `idl_test`, a=testonly

Automatic update from web-platform-tests
Convert Long Tasks API idlharness test to use `idl_test` (#17344)

Because the setup function is allowed to fail, this makes the setup a
bit simpler.

This is to make it easier to add 'hr-time' as a dependency for
web-platform-tests/wpt#17305.
--

wpt-commits: e5167a1ffdd432f1fadd721d63fd1cf42bd67e96
wpt-pr: 17344

UltraBlame original commit: 01d1c2ce6afc75b6c71aead2fb813f25adb1ba87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants