Skip to content

winePackages.fonts: init at 4.0 #63044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2019
Merged

winePackages.fonts: init at 4.0 #63044

merged 2 commits into from
Jun 17, 2019
+26 −3

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Jun 12, 2019 •
edited
Loading

Motivation for this change

Wine's fonts should be a natural candidate for their own subpackage

https://wiki.winehq.org/Packaging

They are a replacement for some Microsoft fonts not available in other
replacement packages, e.g. Tahoma.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@JohnAZoidberg
winePackages.fonts: init at 4.0
66fffe9 
"Wine's fonts should be a natural candidate for their own subpackage"
https://wiki.winehq.org/Packaging

They are a replacement for some Microsoft fonts not available in other
replacement packages.
@JohnAZoidberg
wine: Use proper license attribute
3303bc1
@JohnAZoidberg JohnAZoidberg changed the title Wine fonts winePackages.fonts: init at 4.0 Jun 12, 2019
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 12, 2019
@ofborg ofborg bot requested review from 7c6f434c and bendlas June 12, 2019 21:53
@7c6f434c
Copy link
Member

Does the normal build of Wine also build the fonts? Should they just be an extra output?

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Jun 13, 2019 •
edited
Loading

The fonts are included in the source and don't need building.
I didn't think about an extra output, yes that would be okay, too.
Probably better. Can I name them anyway I want? e.g. fonts.

@7c6f434c
Copy link
Member

Are .fon versions (that are described as needing building) completely useless?

@JohnAZoidberg
Copy link
Member Author

Yes, I think so, except for Wine.
We use .ttf in Linux. For each .ttf there is one .sfd, which are a FontForge plaintext database files. From those the "DOS compatible Bitmap fonts" (.fon) are generated.
https://wiki.winehq.org/Packaging#Fonts

@7c6f434c
Copy link
Member

I think it is possible to have a fonts output. If the normal build does build .FON fonts, then it seems to make sense to just install everything into an extra output.

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Jun 13, 2019 •
edited
Loading

But then someone wanting to use just the fonts has to build wine, even if the fonts are just copied from the source. (Which takes a long time)

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/20

@FRidh
Copy link
Member

FRidh commented Jun 17, 2019

The overhead of performing two separate builds instead of one with an output seems to be quite small here. Considering one build is much faster compared to the other, I think it is fine to have them separated.

@7c6f434c 7c6f434c merged commit 63379e8 into NixOS:master Jun 17, 2019
@JohnAZoidberg JohnAZoidberg deleted the wine-fonts branch June 17, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer

@7c6f434c 7c6f434c

@bendlas bendlas

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JohnAZoidberg @7c6f434c @nixos-discourse @FRidh @matthewbauer