Allow browsers to block mixed content requests from cross-origin tests. #17300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
force-pushed
the
allow-mixed-content-blocking-in-beacon-tests
branch
from
3063aed
to
9d4296d
Compare
toddreifsteck
approved these changes
Jun 12, 2019
beacon/headers/header-referrer.js
Outdated
| assert_true(navigator.sendBeacon(testUrl), "SendBeacon Succeeded"); | ||
| const sentBeacon = navigator.sendBeacon(testUrl); | ||
| assert_true(sentBeacon || mayBeBlockedAsMixedContent, "SendBeacon Succeeded"); | ||
| if (!sentBeacon && mayBeBlockedAsMixedContent) |
There was a problem hiding this comment.
I think this would be easier to read if the pass/fail logic wasn't separated into the assert and the if (!sentBeacon)
Gecko and Blink by default block mixed content requests. As a result, header-referrer-strict-origin-when-cross-origin.https.html, header-referrer-strict-origin.https.html, and beacon/headers/header-referrer-unsafe-url.https.html fail in those two browser engines. Allow the mixed content beacon requests to be blocked in these tests as allowed by the specification: https://www.w3.org/TR/mixed-content/#should-block-fetch https://www.w3.org/TR/mixed-content/#requirements-user-controls Also fixed a bug in header-referrer-strict-origin-when-cross-origin.https.html that it was not testing cross-origin.
rniwa
force-pushed
the
allow-mixed-content-blocking-in-beacon-tests
branch
from
9d4296d
to
a28a06f
Compare
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
…s. (#17300) Gecko and Blink by default block mixed content requests. As a result, header-referrer-strict-origin-when-cross-origin.https.html, header-referrer-strict-origin.https.html, and beacon/headers/header-referrer-unsafe-url.https.html fail in those two browser engines. Allow the mixed content beacon requests to be blocked in these tests as allowed by the specification: https://www.w3.org/TR/mixed-content/#should-block-fetch https://www.w3.org/TR/mixed-content/#requirements-user-controls Also fixed a bug in header-referrer-strict-origin-when-cross-origin.https.html that it was not testing cross-origin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gecko and Blink by default block mixed content requests.
As a result, header-referrer-strict-origin-when-cross-origin.https.html, header-referrer-strict-origin.https.html,
and beacon/headers/header-referrer-unsafe-url.https.html fail in those two browser engines.
Allow the mixed content beacon requests to be blocked in these tests as allowed by the specification:
https://www.w3.org/TR/mixed-content/#should-block-fetch
https://www.w3.org/TR/mixed-content/#requirements-user-controls
Also fixed a bug in header-referrer-strict-origin-when-cross-origin.https.html that it was not testing cross-origin.