Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the workflow of creating room assistance request #56

Merged
merged 4 commits into from Jul 4, 2019
Merged

Update the workflow of creating room assistance request #56

merged 4 commits into from Jul 4, 2019

Conversation

mic4ael
Copy link
Member

@mic4ael mic4ael commented Jun 14, 2019

This is still a Draft since I need to just make sure that everything works fine. And apart from that I need to create proper commits with proper commit messages ;)

SQL command to update the request data:

UPDATE events.requests
SET data = data - 'start_dt' || json_build_object('occurrences', json_build_array(data->>'start_dt'))::JSONB
WHERE type = 'room-assistance' AND data ? 'start_dt';

@mic4ael mic4ael force-pushed the startup-assistance-change branch 9 times, most recently from f406444 to 008d1f6 Compare June 17, 2019 11:31
@mic4ael mic4ael marked this pull request as ready for review June 17, 2019 11:50
@mic4ael mic4ael force-pushed the startup-assistance-change branch 2 times, most recently from 8d41993 to 6f36112 Compare June 17, 2019 11:56
@mic4ael mic4ael force-pushed the startup-assistance-change branch 9 times, most recently from 59a13f8 to 0cc3580 Compare June 18, 2019 10:14
@mic4ael mic4ael force-pushed the startup-assistance-change branch 4 times, most recently from 3c1c3d4 to c08523a Compare June 26, 2019 12:11
@mic4ael mic4ael force-pushed the startup-assistance-change branch 2 times, most recently from 11b70a0 to 457f0c9 Compare June 27, 2019 09:11
@mic4ael mic4ael force-pushed the startup-assistance-change branch 2 times, most recently from f76ea7a to 1534a3e Compare June 27, 2019 12:29
@mic4ael mic4ael requested a review from ThiefMaster June 27, 2019 12:29
@mic4ael mic4ael force-pushed the startup-assistance-change branch 3 times, most recently from 7922ad7 to 26d3930 Compare June 28, 2019 13:02
@mic4ael mic4ael requested a review from ThiefMaster July 1, 2019 06:36
@mic4ael mic4ael force-pushed the startup-assistance-change branch from 26d3930 to 5c079ea Compare July 3, 2019 06:02
pferreir
pferreir approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@pferreir pferreir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done! 👍

@meluru
Copy link

meluru commented Jul 3, 2019

I checked out your branch and I think there's still AM/PM problem.

image

@mic4ael
Copy link
Member Author

mic4ael commented Jul 3, 2019

I checked out your branch and I think there's still AM/PM problem.

image

Did you rebuild assets etc?

@mic4ael
Copy link
Member Author

mic4ael commented Jul 3, 2019

Ok, I see. I will check this out.

@meluru
Copy link

meluru commented Jul 3, 2019

Yes, I checked twice because I also thought this has been solved.

@mic4ael
Copy link
Member Author

mic4ael commented Jul 3, 2019

Yeah, fixed now.

@mic4ael mic4ael force-pushed the startup-assistance-change branch from 5c079ea to cc9994b Compare July 3, 2019 09:55
@ThiefMaster ThiefMaster merged commit 56c76e3 into indico:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pferreir pferreir pferreir approved these changes

@ThiefMaster ThiefMaster ThiefMaster approved these changes

@mvidalgarcia mvidalgarcia mvidalgarcia approved these changes

@meluru meluru meluru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mic4ael @meluru @pferreir @ThiefMaster @mvidalgarcia