Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hpmyroom: init at 11.1.0.0508 #63125

Merged
merged 1 commit into from Sep 13, 2019
Merged

hpmyroom: init at 11.1.0.0508 #63125

merged 1 commit into from Sep 13, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

To join a web conference instantiated by HPE's MyRoom this client can be used.
Everything seems to work, voice chat, screen sharing. It only doesn't show my webcam but I have never used that feature or know how (apart from the "Testing" screen).
Since I can't find a license, I classified it as nonfree and we can't build it with hydra and distribute it in the cache.

There is a Darwin binary but I don't know how to patchelf there or whether it works there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@jpyen
Copy link

jpyen commented Jun 17, 2019

Tested on NixOS 19.03, works like a charm.

@JohnAZoidberg
Copy link
Member Author

I think if you create an account you have access to a private room for testing.

@aanderse
Copy link
Member

@worldofpeace seems like @JohnAZoidberg has done a good job on this (as always) as well as diligent testing... would you agree a merge seems to be in order?

@JohnAZoidberg JohnAZoidberg changed the title hpmyroom: init at 11.0.0.0240 hpmyroom: init at 11.1.0.0508 Aug 31, 2019
@JohnAZoidberg
Copy link
Member Author

Thanks :)
Rebased and updated to the latest version.

worldofpeace
worldofpeace reviewed Sep 1, 2019
View reviewed changes
pkgs/applications/networking/hpmyroom/default.nix Outdated
homepage = "https://myroom.hpe.com";
# TODO: A Darwin binary is available upstream
platforms = [ "x86_64-linux" ];
hydraPlatforms = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. It cannot be redistributed, so hydra must not build it. Is that given with meta.license = lib.licenses.unfree;?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will refuse to evaluate it when unfree. So it's unneeded.

worldofpeace
worldofpeace reviewed Sep 1, 2019
View reviewed changes
pkgs/applications/networking/hpmyroom/default.nix Outdated
stdenv.cc.cc # For libstdc++
] ++ (with gst_all_1; [ gstreamer gst-plugins-base ])
++ (with xorg; [ libX11 ]);
in map (dep: dep.lib or dep.out or dep) deps;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Seemed to work fine without it.

worldofpeace
worldofpeace reviewed Sep 1, 2019
View reviewed changes
pkgs/applications/networking/hpmyroom/default.nix Outdated
glib # For libgobject
stdenv.cc.cc # For libstdc++
] ++ (with gst_all_1; [ gstreamer gst-plugins-base ])
++ (with xorg; [ libX11 ]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary, please reference xorg.libX11 directly.

worldofpeace
worldofpeace suggested changes Sep 1, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The substituteInPlace, wrapProgram, and ln calls really belong in postFixup.
Is this a qt app needing a qt wrapper?

@JohnAZoidberg
Copy link
Member Author

Yes, it is a QT App. But it worked fine without (maybe I didn't try a feature that would have needed a library it cannot find without).

worldofpeace
worldofpeace reviewed Sep 3, 2019
View reviewed changes
pkgs/applications/networking/hpmyroom/default.nix Outdated
'';

qtWrapperArgs = [
''--prefix QT_XKB_CONFIG_ROOT : "${xorg.xkeyboardconfig}/share/X11/xkb"''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
''--prefix QT_XKB_CONFIG_ROOT : "${xorg.xkeyboardconfig}/share/X11/xkb"''
"--prefix QT_XKB_CONFIG_ROOT : '${xorg.xkeyboardconfig}/share/X11/xkb'"

@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 3, 2019 •
edited

f24ef24#r320353661.
I guess a binary app should be called with libsForQt5.callPackage and use mkDerivation which automatically add wrapQtAppsHook to inputs.

@JohnAZoidberg
Copy link
Member Author

Yup, that works, too. Thanks!

@globin globin merged commit ec38981 into NixOS:master Sep 13, 2019
@JohnAZoidberg JohnAZoidberg deleted the hpmyroom branch September 13, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JohnAZoidberg @worldofpeace @jpyen @aanderse @globin