Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grsync: init at 1.2.6 #63164

Merged
merged 1 commit into from Jun 18, 2019
Merged

grsync: init at 1.2.6 #63164

merged 1 commit into from Jun 18, 2019

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Jun 15, 2019

Motivation for this change

Add GRsync (a rsync GUI).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build evals
  • run nix-review without any failures
  • run and tested the binaries

@mmahut
Copy link
Member

mmahut commented Jun 18, 2019

@kuznero thank you, please squash your commits.

@marsam
grsync: init at 1.2.6
5672a51 
Use mirror url

Co-Authored-By: Mario Rodas <marsam@users.noreply.github.com>
@kuznero
Copy link
Member Author

kuznero commented Jun 18, 2019

@kuznero thank you, please squash your commits.

Done

@marsam
Copy link
Contributor

marsam commented Jun 18, 2019

@GrahamcOfBorg build grsync

@marsam marsam merged commit b5cf5ff into NixOS:master Jun 18, 2019
@marsam
Copy link
Contributor

marsam commented Jun 18, 2019

Thanks @kuznero!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@symphorien symphorien symphorien left review comments

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuznero @mmahut @marsam @symphorien