Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

habitat: 0.32.2 -> 0.82.0 #63105

Closed
wants to merge 4 commits into from
Closed

habitat: 0.32.2 -> 0.82.0 #63105

wants to merge 4 commits into from

Conversation

boj
Copy link

@boj boj commented Jun 14, 2019

Motivation for this change

New attempt after closing #46138

Fixes the cargoSha256 problem here for habitat: #62047

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/applications/networking/cluster/habitat/default.nix Outdated Show resolved Hide resolved
@@ -1,24 +1,22 @@
{ lib, fetchFromGitHub, rustPlatform, pkgconfig
, libsodium, libarchive, openssl }:
, libsodium, libarchive, openssl, zeromq }:

with rustPlatform;

buildRustPackage rec {
name = "habitat-${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid repetition

Suggested change
name = "habitat-${version}";
pname = "habitat";

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve seen it either way here, so leaving it as it was unless someone else feels strongly about it.

pkgs/applications/networking/cluster/habitat/default.nix Outdated Show resolved Hide resolved
boj and others added 3 commits June 14, 2019 17:22
Co-Authored-By: Pierre <pierreis@users.noreply.github.com>
Co-Authored-By: Pierre <pierreis@users.noreply.github.com>
Co-Authored-By: Pierre <pierreis@users.noreply.github.com>
@boj
Copy link
Author

boj commented Jun 25, 2019

@rushmorem or perhaps @Mic92 review?

@bhipple bhipple mentioned this pull request Mar 10, 2020
10 tasks
bhipple added a commit to bhipple/nixpkgs that referenced this pull request Mar 17, 2020
The build has been broken on master for a very long time, for want of an
upgrade. This continues the effort put forth here:
NixOS#63105

Note that while there are newer versions than this, upgrading to those requires
getting some Cargo protobuf dependencies to compile. Since this fixes the
failing build, it seems like a good start.

Upstream does not appear to have any Darin builds in their CI, and we do not
have a Darwin maintainer available, so this disables it as well.
@drewrisinger
Copy link
Contributor

Superseded by #82213. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants