Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode{,ium}: 1.35.1 #63107

Merged
merged 2 commits into from Jun 14, 2019
Merged

vscode{,ium}: 1.35.1 #63107

merged 2 commits into from Jun 14, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jun 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

vscodium renamed its executableName to codium. Pushed the change to reflect that.

worldofpeace
worldofpeace approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executed both packages successfully on NixOS x86_64-linux.

Also verified all hashes.

@worldofpeace worldofpeace merged commit 0a7e970 into NixOS:master Jun 14, 2019
@worldofpeace
Copy link
Contributor

backported in

@Synthetica9
Copy link
Member

This update isn't fully backwards compatible, the vscodium binary was renamed to codium. (See VSCodium/vscodium#176). Do we want to symlink this?

@worldofpeace
Copy link
Contributor

For NixOS I'd think most people wouldn't notice because of the desktop file.
But yes I did overlook that, a symlink wouldn't hurt for people who launch it through a shell.

@worldofpeace
Copy link
Contributor

Also note that vscodium was just recently added to stable (last backports for vscode).

@Synthetica9
Copy link
Member

@worldofpeace: #63522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @worldofpeace @Synthetica9