Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 0.61.50 -> 0.65.118 #63040

Merged
merged 1 commit into from Jun 16, 2019
Merged

brave: 0.61.50 -> 0.65.118 #63040

merged 1 commit into from Jun 16, 2019

Conversation

worldofpeace
Copy link
Contributor

Also corrects indentation and adds changelog meta attribute.

https://github.com/brave/brave-browser/blob/v0.65.118/CHANGELOG.md

Motivation for this change

Fixes #63032 though the more subtle issue here is that the version information for this package at repology is incorrect.
Where 0.67.72 is reported as the latest but it should be tracking stable releases at 0.65.x.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
brave: 0.61.50 -> 0.65.118
16f867c 
Also corrects indentation and adds changelog meta attribute.

https://github.com/brave/brave-browser/blob/v0.65.118/CHANGELOG.md
@worldofpeace
Copy link
Contributor Author

If someone would like to fix the repology issues they probably should submit a fix in https://github.com/repology/repology-rules (I think)

@worldofpeace worldofpeace merged commit 72291fb into NixOS:master Jun 16, 2019
@worldofpeace worldofpeace deleted the brave branch June 16, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brave out of date
1 participant
@worldofpeace