Cleaning up ElementTiming and EventTiming observer buffer behavior. #17297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 12, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1654876
branch
3 times, most recently
from
dbda211
to
6c72166
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1654876
branch
3 times, most recently
from
649f850
to
4e5f9dc
Compare
1) Remove methods that handle the buffers separately 2) Remove only buffering until onload 3) Fixing up wpt tests associated with both Bug: 969123 Change-Id: I45991ff9389fe1a626a9911ff19015bcab85bfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654876 Reviewed-by: Steve Kobes <skobes@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#672508}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1654876
branch
from
4e5f9dc
to
5ebff52
Compare
|
Reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 969123
Change-Id: I45991ff9389fe1a626a9911ff19015bcab85bfbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654876
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672508}
Revert "Cleaning up ElementTiming and EventTiming observer buffer behavior."
This reverts commit 2f649e5932821fec499ec23bd95d5f5d24418b0a.
Reason for revert: Test failing on WebKit_Linux_Leak bot (leak):
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/1273
TBR=skobes@chromium.org,npm@chromium.org,eyaich@chromium.org
Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 969123
Change-Id: Ieb9a179ab51f692b6552cdb61db66fdfd056c032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680091
Reviewed-by: Ella Ge eirage@chromium.org
Commit-Queue: Ella Ge eirage@chromium.org
Cr-Commit-Position: refs/heads/master@{#673000}