Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/prosody: update prosody tests #63150

Merged
merged 4 commits into from Aug 20, 2019
Merged

nixos/tests/prosody: update prosody tests #63150

merged 4 commits into from Aug 20, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 15, 2019 •
edited

Motivation for this change

Moved ejabberd and prosody tests to xmpp folder.
Update prosody test to check work in local network.
Add test prosody test with mysql database.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin mentioned this pull request Jun 15, 2019
Merged
10 tasks
@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 15, 2019

@GrahamcOfBorg test prosody prosodyMysql

@Izorkin Izorkin mentioned this pull request Jun 20, 2019
Merged
10 tasks
teto
teto approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it tests more in-depth the xmpp prosody server.

@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 20, 2019

@GrahamcOfBorg test prosody prosodyMysql

@ajs124 ajs124 mentioned this pull request Aug 6, 2019
Merged
10 tasks
@aanderse
Copy link
Member

aanderse commented Aug 9, 2019

@ajs124 can we get your approval please?

@teto
Copy link
Member

teto commented Aug 9, 2019

@ajs124 are you fine with me merging this first ? you can update your PR later on

@ajs124
Copy link
Member

ajs124 commented Aug 9, 2019

@aanderse: Sure! In general this looks fine, although I cannot really speak to the prosody part of it. The one thing which should be fixed before merging is that the ejabberd wasn't actually moved, but copied. So if I'm not mistaken, we would end up with two ejabberd test.

@teto: Fine by me.

@ajs124
Copy link
Member

ajs124 commented Aug 19, 2019

ping

@aanderse
Copy link
Member

@Izorkin can you please address the comment about two ejabberd tests by @ajs124?

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 20, 2019

Fixed error - not full moved ejabberd.nix to folder nixos/tests/xmpp

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 20, 2019

@GrahamcOfBorg test prosody prosodyMysql
@GrahamcOfBorg test ejabberd

@teto teto merged commit 0f32b32 into NixOS:master Aug 20, 2019
@Izorkin Izorkin deleted the prosody-test branch August 20, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @aanderse @teto @ajs124