pythonPackages.infix: init at 1.2 #63075
Conversation
ofborg
bot
added
6.topic: python
8.has: package (new)
|
Top of the
So I don't see a reason for this to be in nixpkgs. |
|
I intend to merge `pycategories` to nixpkgs and this is a dependency. I know it is unmaintained, but it works and we use it.
https://gitlab.com/danielhones/pycategories
…--
Daniel Vianna
On 14 Jun 2019, at 9:02 am, worldofpeace ***@***.***> wrote:
Top of the README.md says
This project is an unmaintained experiment. Don't use it for production code.
So I don't see a reason for this to be in nixpkgs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Ahh now I understand. Also note that it's totally acceptable to have one pr with multiple packages, i.e adding this and However I really think having this package globally available isn't a good idea. You can't submit issues upstream or submit prs (maintained fork would be needed). Especially when the author vehemently directs you not to even use it. So what you can do is add it privately for ...
let
infix = callPackage ./infix.nix {};
in
buildPythonPackage {
... |
| sha256 = "a1bfdcf875bc072f41e426d0673f2e3017750743bb90cc725fffb292eb09648c"; | ||
| }; | ||
|
|
||
| doCheck = true; |
There was a problem hiding this comment.
| doCheck = true; | |
| # No Tests | |
| doCheck = false; |
I don't see any tests.
|
Cool, let's close it then and I'll have it as a private package to |
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/we-need-more-defined-guidelines-for-package-inclusion/3592/7 |
Motivation for this change
New package.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)