Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expansion of backdrop-filter input for pixel-moving filters #17310

Merged
merged 1 commit into from Jun 13, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 13, 2019

See [1] for the PR for the spec change. Essentially, with this CL,
the input to the filter will be the bounding box of the element
with backdrop-filter. The bounds will not be expanded for pixel-
moving filters, and will not include extra border for children.

Note that the rebaselined layout tests are all for very small
single-pixel errors, except for backdrop_filter_blur_outsets.png
and backdrop-filter-boundary-expected.png, which change because
of this new behavior.

This needs a (small) spec change, but it will be beneficial in
these four ways:

  • It agrees more closely with existing Safari behavior.
  • It improves performance, by filtering fewer pixels in the
    case of pixel-moving filters.
  • Developers have been disappointed with the existing behavior
    of bringing in pixels from outside the bounds of the
    element, and have requested a way to turn this behavior off.
    See the discussion starting at [2].
  • It eliminates the problem of crbug.com/972173, where content
    outside the renderer viewport can get dragged into the filter.

[1] w3c/fxtf-drafts#342
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=497522#c196

Bug: 972173,497522
Change-Id: I18cc6d08cf9fde263b9e166b5e96ea57a1c41973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650418
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668894}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Remove expansion of filter input for pixel-moving filters Remove expansion of backdrop-filter input for pixel-moving filters Jun 13, 2019
See [1] for the PR for the spec change. Essentially, with this CL,
the input to the filter will be the bounding box of the element
with backdrop-filter. The bounds will not be expanded for pixel-
moving filters, and will not include extra border for children.

Note that the rebaselined layout tests are all for very small
single-pixel errors, except for backdrop_filter_blur_outsets.png
and backdrop-filter-boundary-expected.png, which change because
of this new behavior.

This needs a (small) spec change, but it will be beneficial in
these four ways:
 - It agrees more closely with existing Safari behavior.
 - It improves performance, by filtering fewer pixels in the
   case of pixel-moving filters.
 - Developers have been disappointed with the existing behavior
   of bringing in pixels from outside the bounds of the
   element, and have requested a way to turn this behavior off.
   See the discussion starting at [2].
 - It eliminates the problem of crbug.com/972173, where content
   outside the renderer viewport can get dragged into the filter.

[1] w3c/fxtf-drafts#342
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=497522#c196

Bug: 972173,497522
Change-Id: I18cc6d08cf9fde263b9e166b5e96ea57a1c41973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650418
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668894}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants