[WIP] gitlab: 11.10.4 -> 11.11.3 #63056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The builds appears to fail which seems possibly an usage of a different ping @flokli for assistance |
|
Here, it fails in the grpc gem too, but for me while building boringssl, which seems to be vendored inside the grpc gem 😆 I looked into https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/ruby-modules/gem-config/default.nix#L200, so we seem to be able to build a grpc gem successfully, but I'm not sure how to build it properly with bundix. |
|
I was mistaken - had a remote builder, which swallowed some of the output. For me, it fails in the It looks like the |
|
My wild guess would be that the |
|
The It is missing a command character. It looks to me like the grpc build system expects the |
|
I have fixed this and opened #64550 bumping gitlab to 12.0.3. |
|
Thank you, moving this party to #64550. |
flokli
pushed a commit
to bgamari/nixpkgs
that referenced
this pull request
Jul 14, 2019
This is a major version bump but things were generally straightforward save two wrinkles: * it is necessary to ignore collisions in the gitlab bundler environment as both `omniauth_oauth2_generic` and `apollo_upload_server` provide a `console` executable. * grpc had to be patched since its build system expects the `AR` environment variable to contain not just the path to `ar` but also the `rpc` flags (see the discussion in nixpkgs NixOS#63056).
globin
pushed a commit
to mayflower/nixpkgs
that referenced
this pull request
Jul 16, 2019
This is a major version bump but things were generally straightforward save two wrinkles: * it is necessary to ignore collisions in the gitlab bundler environment as both `omniauth_oauth2_generic` and `apollo_upload_server` provide a `console` executable. * grpc had to be patched since its build system expects the `AR` environment variable to contain not just the path to `ar` but also the `rpc` flags (see the discussion in nixpkgs NixOS#63056).
flokli
pushed a commit
to flokli/nixpkgs
that referenced
this pull request
Aug 20, 2019
This is a major version bump but things were generally straightforward save two wrinkles: * it is necessary to ignore collisions in the gitlab bundler environment as both `omniauth_oauth2_generic` and `apollo_upload_server` provide a `console` executable. * grpc had to be patched since its build system expects the `AR` environment variable to contain not just the path to `ar` but also the `rpc` flags (see the discussion in nixpkgs NixOS#63056). (cherry picked from commit 363b352)
ciil
pushed a commit
to mayflower/nixpkgs
that referenced
this pull request
Aug 21, 2019
This is a major version bump but things were generally straightforward save two wrinkles: * it is necessary to ignore collisions in the gitlab bundler environment as both `omniauth_oauth2_generic` and `apollo_upload_server` provide a `console` executable. * grpc had to be patched since its build system expects the `AR` environment variable to contain not just the path to `ar` but also the `rpc` flags (see the discussion in nixpkgs NixOS#63056). (cherry picked from commit 363b352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Major gitlab upgrade 11.10.4 -> 11.11.3.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)