[Gecko Bug 1557079] Remove install_dep from wptrunner setup.py file #17313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reading the confguration from requriements.txt which only works in the simple case where that's a list of package names. In practice the only thing that cares about this file is tox and it already installs the requirements files directly. Differential Revision: https://phabricator.services.mozilla.com/D33812 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1557079 gecko-commit: 7148d66e15231da32c5a7e9ec279ce668c8180a8 gecko-integration-branch: autoland gecko-reviewers: gsnedders
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reading the confguration from requriements.txt which only
works in the simple case where that's a list of package names. In
practice the only thing that cares about this file is tox and it already
installs the requirements files directly.
Differential Revision: https://phabricator.services.mozilla.com/D33812
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1557079
gecko-commit: 7148d66e15231da32c5a7e9ec279ce668c8180a8
gecko-integration-branch: autoland
gecko-reviewers: gsnedders