Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gimp: 2.10.10 → 2.10.12 #63115

Merged
merged 2 commits into from Jun 14, 2019
Merged

gimp: 2.10.10 → 2.10.12 #63115

merged 2 commits into from Jun 14, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 14, 2019 •
edited

Motivation for this change

Supercedes: #62356

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@jtojnar jtojnar merged commit d42ed2d into NixOS:master Jun 14, 2019
@jtojnar jtojnar deleted the gimp-2.10.12 branch June 14, 2019 10:07
@jtojnar jtojnar mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @mmahut