fbthrift: init at 2019.06.10.00 #63097

pierreis · 2019-06-13T18:36:06Z

Motivation for this change

Added Fbthrift library and its dependencies

New packages:

Fbthrift (v2019.06.10.00)
Fizz (v2019.06.10.00)
Wangle (v2019.06.10.00)
rsocket-cpp (git master)

Updated packages

Folly (v2019.05.27.00 >> v2019.06.10.00)

Fixed packages

Fixed fmt cmake manifest generation

Things done

pierreis · 2019-06-13T18:37:48Z

Referencing maintainers for updated dependencies:

@abbradar (Folly)
@jeroendehaas (Fmt)

pkgs/development/libraries/fmt/default.nix

abbradar · 2019-06-13T19:28:13Z

Please split commits into separate ones for different derivations.

pkgs/development/libraries/wangle/default.nix

pkgs/development/libraries/fbthrift/default.nix

pkgs/development/libraries/fmt/default.nix

pierreis · 2019-06-13T22:10:49Z

Comments have all been fixed.
Commits have been split by derivation.

stale · 2020-06-13T16:46:52Z

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the related code and @ mention them in a comment.
Ask on the NixOS Discourse.
Ask on the #nixos channel on irc.freenode.net.

stale · 2021-06-06T19:58:03Z

I marked this as stale due to inactivity. → More info

doronbehar · 2021-06-10T06:12:17Z

@pierreis do you still want this to get in? now fmt and folly are in a merge conflict.

SuperSandro2000 · 2021-06-10T19:04:54Z

pkgs/development/libraries/wangle/default.nix

+      abstractions for building services in a consistent, modular, and
+      composable way.
+    '';
+    homepage = https://github.com/facebook/wangle;


Suggested change

homepage = https://github.com/facebook/wangle;

homepage = "https://github.com/facebook/wangle";

SuperSandro2000 · 2021-06-10T19:04:58Z

pkgs/development/libraries/wangle/default.nix

+    openssl
+  ];
+
+  meta = with stdenv.lib; {


Suggested change

meta = with stdenv.lib; {

meta = with lib; {

SuperSandro2000 · 2021-06-10T19:05:05Z

pkgs/development/libraries/wangle/default.nix

+    double-conversion
+    fizz
+    folly
+    gtest


is this a checkInput?

SuperSandro2000 · 2021-06-10T19:05:15Z

pkgs/development/libraries/rsocket-cpp/default.nix

+    openssl
+  ];
+
+  meta = with stdenv.lib; {


Suggested change

meta = with stdenv.lib; {

meta = with lib; {

SuperSandro2000 · 2021-06-10T19:05:32Z

pkgs/development/libraries/rsocket-cpp/default.nix

+
+  meta = with stdenv.lib; {
+    description = "C++ implementation of RSocket";
+    homepage = https://github.com/rsocket/rsocket-cpp;


Suggested change

homepage = https://github.com/rsocket/rsocket-cpp;

homepage = "https://github.com/rsocket/rsocket-cpp";

SuperSandro2000 · 2021-06-10T19:06:04Z

pkgs/development/libraries/fbthrift/default.nix

+
+  meta = with stdenv.lib; {
+    description = "Facebook's branch of Apache Thrift";
+    homepage = https://github.com/facebook/fbthrift;


Suggested change

homepage = https://github.com/facebook/fbthrift;

homepage = "https://github.com/facebook/fbthrift";

SuperSandro2000 · 2021-06-10T19:06:09Z

pkgs/development/libraries/fizz/default.nix

+    zlib
+  ];
+
+  meta = with stdenv.lib; {


Suggested change

meta = with stdenv.lib; {

meta = with lib; {

SuperSandro2000 · 2021-06-10T19:06:14Z

pkgs/development/libraries/fizz/default.nix

+
+  meta = with stdenv.lib; {
+    description = "C++14 implementation of the TLS-1.3 standard";
+    homepage = https://github.com/facebookincubator/fizz;


Suggested change

homepage = https://github.com/facebookincubator/fizz;

homepage = "https://github.com/facebookincubator/fizz";

SuperSandro2000 · 2021-06-10T19:06:23Z

pkgs/development/libraries/fmt/default.nix

+      substituteInPlace $out/lib/cmake/fmt/fmt-targets.cmake \
+          --replace "\''${_IMPORT_PREFIX}/include" "$dev/include"


Suggested change

substituteInPlace $out/lib/cmake/fmt/fmt-targets.cmake \

--replace "\''${_IMPORT_PREFIX}/include" "$dev/include"

substituteInPlace $out/lib/cmake/fmt/fmt-targets.cmake \

--replace "\''${_IMPORT_PREFIX}/include" "$dev/include"

SuperSandro2000 · 2021-06-10T19:06:29Z

pkgs/development/libraries/rsocket-cpp/default.nix

+
+stdenv.mkDerivation rec {
+  pname = "rsocket-cpp";
+  version = "2019-06-13";


Suggested change

version = "2019-06-13";

version = "unstable-2019-06-13";

stale · 2022-01-09T00:07:02Z

I marked this as stale due to inactivity. → More info

doronbehar · 2022-01-09T21:01:00Z

Closing due to OP not responding.

pierreis force-pushed the fbthrift branch from 43b6b8d to 6e014f4 Compare June 13, 2019 18:46

ofborg bot added the 8.has: package (new) label Jun 13, 2019

ofborg bot requested a review from abbradar June 13, 2019 18:50

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jun 13, 2019

jeroendehaas reviewed Jun 13, 2019

View reviewed changes

pkgs/development/libraries/fmt/default.nix Outdated Show resolved Hide resolved

jtojnar reviewed Jun 13, 2019

View reviewed changes

pierreis added 6 commits June 13, 2019 16:17

folly: 2019.05.27.00 -> 2019.06.10.00

a23f3cc

fizz: init at v2019.06.10.00

3c83ba9

wangle: init at v2019.06.10.00

6b09af1

rsocket-cpp: init at 2019-06-13

eb56994

fmt: fix generated cmake manifest

d9b030c

fbthrift: init at 2019.06.10.00

f622095

pierreis force-pushed the fbthrift branch from 6e014f4 to f622095 Compare June 13, 2019 22:08

doronbehar approved these changes Dec 16, 2019

View reviewed changes

ryantm added the 2.status: merge conflict label Jan 4, 2020

sheenobu mentioned this pull request May 3, 2020

fmt: bad INTERFACE_INCLUDE_DIRECTORIES in cmake targets for fmt #86622

Closed

sheenobu mentioned this pull request May 23, 2020

fmt: fix cmake include path #88723

Closed

10 tasks

stale bot added the 2.status: stale label Jun 13, 2020

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

stale bot removed the 2.status: stale label Oct 3, 2020

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

stale bot added the 2.status: stale label Jun 6, 2021

stale bot removed the 2.status: stale label Jun 10, 2021

doronbehar added the 2.status: stale label Jun 10, 2021

SuperSandro2000 changed the title ~~fbthrift: init at v2019.06.10.00~~ fbthrift: init at 2019.06.10.00 Jun 10, 2021

stale bot removed the 2.status: stale label Jun 10, 2021

SuperSandro2000 requested changes Jun 10, 2021

View reviewed changes

stale bot added the 2.status: stale label Jan 9, 2022

doronbehar closed this Jan 9, 2022

kylesferrazza mentioned this pull request Jul 17, 2022

Update watchman (and create all the packages it now depends on) #181787

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fbthrift: init at 2019.06.10.00 #63097

fbthrift: init at 2019.06.10.00 #63097

pierreis commented Jun 13, 2019 •

edited

Loading

pierreis commented Jun 13, 2019 •

edited

Loading

abbradar commented Jun 13, 2019

pierreis commented Jun 13, 2019

stale bot commented Jun 13, 2020

stale bot commented Jun 6, 2021

doronbehar commented Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

SuperSandro2000 Jun 10, 2021

stale bot commented Jan 9, 2022

doronbehar commented Jan 9, 2022

	homepage = https://github.com/facebook/wangle;
	homepage = "https://github.com/facebook/wangle";

	homepage = https://github.com/rsocket/rsocket-cpp;
	homepage = "https://github.com/rsocket/rsocket-cpp";

	homepage = https://github.com/facebook/fbthrift;
	homepage = "https://github.com/facebook/fbthrift";

	homepage = https://github.com/facebookincubator/fizz;
	homepage = "https://github.com/facebookincubator/fizz";

		substituteInPlace $out/lib/cmake/fmt/fmt-targets.cmake \
		--replace "\''${_IMPORT_PREFIX}/include" "$dev/include"

fbthrift: init at 2019.06.10.00 #63097

fbthrift: init at 2019.06.10.00 #63097

Conversation

pierreis commented Jun 13, 2019 • edited Loading

Motivation for this change

Things done

pierreis commented Jun 13, 2019 • edited Loading

abbradar commented Jun 13, 2019

pierreis commented Jun 13, 2019

stale bot commented Jun 13, 2020

stale bot commented Jun 6, 2021

doronbehar commented Jun 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Jan 9, 2022

doronbehar commented Jan 9, 2022

pierreis commented Jun 13, 2019 •

edited

Loading

pierreis commented Jun 13, 2019 •

edited

Loading