[Gecko Bug 1477977] [marionette] Handle "tabmodal-dialog-loaded" to observe new tab modal dialogs. #17319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dialogs. Differential Revision: https://phabricator.services.mozilla.com/D34138 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1477977 gecko-commit: e9e20d087e338275a4ceae79e91d7a8e2f882f91 gecko-integration-branch: autoland gecko-reviewers: maja_zf
…tus between tabs. Differential Revision: https://phabricator.services.mozilla.com/D34140 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1477977 gecko-commit: 4651b31ffe5c012b5112fc3047c29d0d4a8f9594 gecko-integration-branch: autoland gecko-reviewers: webdriver-reviewers, automatedtester
wpt-pr-bot
approved these changes
Jun 13, 2019
|
The failures here is Chrome mostly failing with a timeout failure for the new tab-modal test, which checks for retained tab modals across tabs. Looks like it cannot handle it yet. CC'ing @JohnChen0 for info. Update: Whereby this is only for the verify job, with Chrome experimental it is all fine. So maybe there was a race and the clean-up of a test was not successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D34138
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1477977
gecko-commit: e9e20d087e338275a4ceae79e91d7a8e2f882f91
gecko-integration-branch: autoland
gecko-reviewers: maja_zf