Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picolisp: fix help functionality #63139

Merged
merged 1 commit into from Jun 16, 2019
Merged

picolisp: fix help functionality #63139

merged 1 commit into from Jun 16, 2019

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Jun 14, 2019 •
edited

Currently, trying to use help results in something like this:

: (help 'db)
========================================
w3m: Can't exec
=======================================

By including w3m as an input, the behaviour changes to:

: (help 'db)
========================================
(db 'sym 'cls ['hook] 'any ['sym 'any ..]) -> sym | NIL
Returns a database object of class cls, where the values for the sym arguments
correspond to the any arguments. If a matching object cannot be found, NIL is
returned. sym, cls and hook should specify a tree for cls or one of its
superclasses. See also aux, collect, request, fetch, init and step.

========================================
-> db
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c June 14, 2019 21:56
@7c6f434c
Copy link
Member

Does it work if w3m is in PATH set by wrapper but not a buildInput?

@yrashk
Copy link
Contributor Author

yrashk commented Jun 15, 2019

Yeah, if it was just in buildInput this didn't work, hence the wrapper. Am I missing something?

@7c6f434c
Copy link
Member

I think if it is in the wrapper, it is not needed in buildInputs (the other way round to what you tried)

@yrashk
picolisp: fix help functionality
6278dbf 
Currently, trying to use help results in something like this:

```
: (help 'db)
========================================
w3m: Can't exec
=======================================
```

By including `w3m` as an input, the behaviour changes to:

```
: (help 'db)
========================================
(db 'sym 'cls ['hook] 'any ['sym 'any ..]) -> sym | NIL
Returns a database object of class cls, where the values for the sym arguments
correspond to the any arguments. If a matching object cannot be found, NIL is
returned. sym, cls and hook should specify a tree for cls or one of its
superclasses. See also aux, collect, request, fetch, init and step.

========================================
-> db
```
@yrashk
Copy link
Contributor Author

yrashk commented Jun 16, 2019

@7c6f434c Michael, I've updated the commit with your suggestion.

@7c6f434c
Copy link
Member

Thank you

@7c6f434c 7c6f434c merged commit 2edd48b into NixOS:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yrashk @7c6f434c