SMS API: Clean up SMS API mojom interface #17304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1654272
branch
4 times, most recently
from
736f641
to
eb21961
Compare
This CL cleans up the SMS API mojom interface based on the suggestions on the following issue link. No behavioral changes for the SMS API mojom interface. Bug: 968584 Change-Id: Iba707dd9a94f75cb28b7409f930e75b0f6f2f792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654272 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#670694}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1654272
branch
from
eb21961
to
0b49656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL cleans up the SMS API mojom interface based on the suggestions
on the following issue link. No behavioral changes for the SMS API
mojom interface.
Bug: 968584
Change-Id: Iba707dd9a94f75cb28b7409f930e75b0f6f2f792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654272
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670694}