Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1554699] Split up and elaborate on MediaStream-MediaElement-srcObject.https.html. #17299

Merged
merged 3 commits into from Jun 13, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

This does several things:

  • Split the test up, so one assert doesn't fail the entire test suite
  • Check preload, playbackRate and defaultPlaybackRate attributes after unsetting srcObject
  • Check setting currentTime before loading (default playback start position),
    and after loading (official playback position) separately
  • Check that duration is changed to a real number on ending
  • Check that HAVE_ENOUGH_DATA is reached by only assigning srcObject
  • And other minor things and formatting

Differential Revision: https://phabricator.services.mozilla.com/D33647

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1554699
gecko-commit: a6187e39bf7c0ba5d9ba36d570a1b6d8fc4f7ecd
gecko-integration-branch: autoland
gecko-reviewers: jib

This does several things:
- Split the test up, so one assert doesn't fail the entire test suite
- Check preload, playbackRate and defaultPlaybackRate attributes after unsetting srcObject
- Check setting currentTime before loading (default playback start position),
  and after loading (official playback position) separately
- Check that duration is changed to a real number on ending
- Check that HAVE_ENOUGH_DATA is reached by only assigning srcObject
- And other minor things and formatting

Differential Revision: https://phabricator.services.mozilla.com/D33647

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1554699
gecko-commit: a6187e39bf7c0ba5d9ba36d570a1b6d8fc4f7ecd
gecko-integration-branch: autoland
gecko-reviewers: jib
…ing a MediaStream.

Differential Revision: https://phabricator.services.mozilla.com/D33655

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1554699
gecko-commit: 7727cef089cd73f8dc0f76afd2b8309603470709
gecko-integration-branch: autoland
gecko-reviewers: jib
…ved.

Since the media element is playing directly after play(), not waiting for the
readyState to advance before play()ing could leave the play promise from play()
unhandled until cleanup, when it would be rejected by the load algorithm.

This would happen if a timeupdate event is raised before the first frame comes
in to update the readyState, which resolves the play promise.

Waiting for the readyState to advance before play()ing seems like the cleanest
fix wrt testing currentTime after the first timeupdate event.

Depends on D33655

Differential Revision: https://phabricator.services.mozilla.com/D34686

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1554699
gecko-commit: 89350b209bcecaa0f0ec46769647cee3f0d8084b
gecko-integration-branch: autoland
gecko-reviewers: jib
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@jgraham jgraham merged commit 270ef73 into master Jun 13, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1554699 branch June 13, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants