[LayoutNG] the real youtube button fix #17303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 12, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1652653
branch
2 times, most recently
from
7d9d110
to
d171fef
Compare
Previous fix worked by eliminating cacheing of OOF Legacy positioned elements. It was not the right fix. https://chromium-review.googlesource.com/c/chromium/src/+/1649086 This fix backs out the original fix, and implements the correct fix: OOF objects positioned by RunLegacyLayout could end up with a cached layout result that had an old constraint space. Fix is to force re-cache with new constraint space. Bug: 970171 Change-Id: Ia9a7faea929083566f406db371ddcef058f2e4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652653 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#668709}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1652653
branch
from
d171fef
to
d7314fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix worked by eliminating cacheing of OOF Legacy
positioned elements. It was not the right fix.
https://chromium-review.googlesource.com/c/chromium/src/+/1649086
This fix backs out the original fix, and implements the correct fix:
OOF objects positioned by RunLegacyLayout could end up
with a cached layout result that had an old constraint space.
Fix is to force re-cache with new constraint space.
Bug: 970171
Change-Id: Ia9a7faea929083566f406db371ddcef058f2e4ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652653
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668709}