Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPAdes: init at 3.13.1 #63082

Merged
merged 2 commits into from Oct 3, 2019
Merged

SPAdes: init at 3.13.1 #63082

merged 2 commits into from Oct 3, 2019

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Jun 13, 2019

Motivation for this change

Bioinformatic tool used into my laboratory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/applications/science/biology/spades/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/spades/default.nix Outdated Show resolved Hide resolved
@luispedro
Copy link
Contributor

+1 for spades, this is an important tool in bioinformatics. I'd love to have this in nix.

@bzizou
Copy link
Contributor Author

bzizou commented Oct 3, 2019

Sorry for the mess with merge conflicts that triggered requests for a bunch of reviewers...

@zimbatm zimbatm merged commit 1ba3f3f into NixOS:master Oct 3, 2019
@bzizou bzizou deleted the spades branch March 23, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants