Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 75.0.3770.80 -> 75.0.3770.90 #63136

Merged
merged 1 commit into from Jun 18, 2019
Merged

chromium: 75.0.3770.80 -> 75.0.3770.90 #63136

merged 1 commit into from Jun 18, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jun 14, 2019

Motivation for this change

Fixes CVE-2019-5842 Use-after-free in Blink

https://chromereleases.googleblog.com/2019/06/stable-channel-update-for-desktop_13.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested chromium (stable) only where everything seems to be working.

@andir
Copy link
Member

andir commented Jun 14, 2019 

hash mismatch in fixed-output derivation '/nix/store/j1il421fdnqv5y5bkvhny4gl1648l9s3-chromium-76.0.3809.25.tar.xz':                                          
  wanted: sha256:0f9qjhxvk8sajj7qa061crfmln65q7sniylrgp0qijwyw6xrmddi
  got:    sha256:0pq7q7plbmfg2f6m74wl2l19k15ik2mvw56bfzk4c9cdns8w6b8a

@ivan

@ivan
Copy link
Member Author

ivan commented Jun 14, 2019 •
edited

Sorry about that, I ran ./update.sh but it somehow made beta's hash the same as for stable. Fixed. Hopefully sha256bin64 is fine; my build is still going.

@ivan
Copy link
Member Author

ivan commented Jun 18, 2019

I undid the additional chromiumDev bump because the very latest version does not build:

./ios/build/tools/convert_gn_xcodeproj.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/k4gf6ajykc2i8zp2zk5x0h7mf4r08cv6-python-2.7.16/bin/python"
./ios/build/tools/setup-gn.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/k4gf6ajykc2i8zp2zk5x0h7mf4r08cv6-python-2.7.16/bin/python"
configuring
ERROR Unresolved dependencies.
//third_party/perfetto/gn:zlib(//build/toolchain/linux:clang_x64)
  needs //third_party/zlib:zlib_config(//build/toolchain/linux:clang_x64)

builder for '/nix/store/aldllm7vfmjcah326yjhiw2wdri6i58m-chromium-unwrapped-77.0.3824.6.drv' failed with exit code 1

Maybe fixable, but I don't want to hold up the stable update.

@andir andir self-assigned this Jun 18, 2019
@andir andir merged commit 5a74f84 into NixOS:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andir andir

Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @andir @samueldr