Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ddclient extraConfig #63087

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fix ddclient extraConfig #63087

merged 1 commit into from
Jun 20, 2019
+1 −1

Conversation

matthiasbeyer
Copy link
Contributor

This superceeds #39092

According to commit ba0ba6d (which is cherry-picked here, but completely rewritten), the domains should be last.

This commit fixes this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Not tested at all.

Unfortunately, ddclient has no maintainer but @dezgeg was the person who edited the file recently (as in "was the last one touching the ddlcient package defintion), so they get pinged here (sorry).

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 13, 2019
@matthiasbeyer matthiasbeyer mentioned this pull request Jun 13, 2019
Closed
8 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 13, 2019
@LasseBlaauwbroek @matthiasbeyer
Fix ddclient extraConfig
0515392 
The the extraConfig variable is added below the domain variable in the
ddclient config file. The domain variable should always be last.

(cherry picked from commit ba0ba6d)
@matthiasbeyer
Copy link
Contributor Author

Merge?

@matthewbauer matthewbauer merged commit 808d6fc into NixOS:master Jun 20, 2019
@matthiasbeyer matthiasbeyer deleted the fix-ddclient-extraconfig branch June 21, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @matthewbauer @LasseBlaauwbroek