Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome-control-center: Add mutter to dependencies #63124

Merged
merged 1 commit into from Jun 15, 2019
Merged

gnome3.gnome-control-center: Add mutter to dependencies #63124

merged 1 commit into from Jun 15, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 14, 2019

Motivation for this change

#59765 fixed the keybndings issue #19590 only partially, we still need to make the gschemas available.

Closes: #63123

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
gnome3.gnome-control-center: Add mutter to dependencies
fc4cc85 
NixOS#59765 fixed the keybndings issue NixOS#19590 only partially, we still need to
make the gschemas available.
@arianvp
Copy link
Member

arianvp commented Jun 14, 2019

Is this backportable to 19.03 by any chance?

@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 14, 2019

Probably

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 14, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot requested review from worldofpeace and hedning June 14, 2019 16:20
worldofpeace
worldofpeace approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launched gnome-control-center like

Open the Keyboard settings option through the search bar.

Screenshot from 2019-06-14 13 05 42

Kinda funny that we missed this.

@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 14, 2019 •
edited

Actually I don't understand what adding this to buildInputs is going to affect the wrapping when we already do
XDG_DATA_DIRS : "${mutter}/share"?

Edit: right gsettings schemas ${mutter}/share/gsettings-schemas/${mutter.name}/

@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 14, 2019

We need it for glib setup hook to add schemas (which are in subdirectory) there as well.

@worldofpeace
Copy link
Contributor

Yep GSETTINGS_SCHEMAS_PATH set from the glib setup-hook that gets added with wrapGAppsHook

hedning
hedning approved these changes Jun 15, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtojnar jtojnar merged commit 33a0ef8 into NixOS:master Jun 15, 2019
@jtojnar jtojnar deleted the g-c-c-mutter-schemas branch June 15, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gnome3 settings doesn't open anymore
4 participants
@jtojnar @arianvp @worldofpeace @hedning