Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug. Replace networking.enableIntel2200BGFirmware #63091

Closed
wants to merge 1 commit into from
Closed

Fix bug. Replace networking.enableIntel2200BGFirmware #63091

wants to merge 1 commit into from

Conversation

NilsIrl
Copy link
Member

@NilsIrl NilsIrl commented Jun 13, 2019

Motivation for this change

When running nixos-install the error error: The option networking.enableIntel2200BGFirmware defined in /mnt/etc/nixos/hardware-configuration.nix does not exist shows up.

To fix this I was told to replace it with hardware.enableRedistributableFirmware by @srhb on IRC.

Things done

Installed nixos on a laptop.

@NilsIrl
Copy link
Member Author

NilsIrl commented Jun 13, 2019

Conversation on IRC: https://logs.nix.samueldr.com/nixos/2019-06-13
I was under the username ffdfdfdf

@matthewbauer
Copy link
Member

It looks like this option still exists:

https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/hardware/network/intel-2200bg.nix#L9

Not sure what is going on?

@NilsIrl
Copy link
Member Author

NilsIrl commented Jun 20, 2019

@matthewbauer I am not sure either. I was told to do this PR on IRC.
What is sure though is the nixos-generate-config produced a config that didn't work and that manually changing the hardware-configuration to hardware.enableRedistributableFirmware fixed it.

@srhb
Copy link
Contributor

srhb commented Jun 23, 2019

@matthewbauer I think that file is an accidental leftover -- it's no longer included in module-list.nix -- and should just be deleted. As far as I can see all relevant files are in the redist blob.

@matthewbauer
Copy link
Member

matthewbauer commented Jun 24, 2019 •
edited

According to this it does not have the right firmware: 0b72e7e

and #12980

@matthewbauer
Copy link
Member

matthewbauer commented Jun 24, 2019 •
edited

partial fix pushed in 8768d1c

Don't want to lose the fix for #12980. It might be that some of the older firmware is provided but not others in linux-firmware-nonfree??

vmandela pushed a commit to vmandela/nixpkgs that referenced this pull request Jun 24, 2019
@matthewbauer
nixos: add hardware/network/intel-2200bg.nix to module-list
8768d1c 
this is referenced by nixos-generate-config.pl. See
NixOS#63091 for more discussion.
matthewbauer added a commit that referenced this pull request Jun 24, 2019
@matthewbauer
nixos: add hardware/network/intel-2200bg.nix to module-list
d5a3e5f 
this is referenced by nixos-generate-config.pl. See
#63091 for more discussion.

(cherry picked from commit 8768d1c)
@aanderse
Copy link
Member

ping (triage)
Seems important for 19.09...

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@SuperSandro2000
Copy link
Member

Closing due to inactivity and 19.09 being long EOL. Feel free to reopen the discussion.

@NilsIrl NilsIrl deleted the master branch June 29, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor Awaiting requested review from bjornfor

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NilsIrl @matthewbauer @srhb @aanderse @SuperSandro2000 @Janik-Haag