Disallow symlinks #17315
Merged
Disallow symlinks #17315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
gsnedders,
jdm,
jugglinmike,
zcorpan and
zqzhang
Would be good to disallow whitelisting this one somehow, but that's a larger change.
jgraham
force-pushed
the
disallow_symlinks
branch
from
1e3461e
to
fdda789
Compare
|
Pretty sure the failing tests are unrelated to this change. |
Co-Authored-By: Robert Ma <bob1211@gmail.com>
|
Works on my end. We just need to copy @Hexcles' suggestion to the test expectation. I'll squash and merge once the build passes. |
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
* Lint to ensure there are no symlinks in the tree. Would be good to disallow whitelisting this one somehow, but that's a larger change. * Remove symlink * Update tools/lint/lint.py Co-Authored-By: Robert Ma <bob1211@gmail.com> * Update tools/lint/tests/test_path_lints.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlinks don't work well cross-platform and are forbidden from the Gecko tree, so we should forbid them here also.