Add an initial test for wasm multi-value. #17314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last test appears to work in the V8 shell when passing CC @rossberg |
littledan
reviewed
Jun 17, 2019
| assert_true(Array.isArray(swapped)); | ||
| assert_equals(Object.getPrototypeOf(swapped), Array.prototype); | ||
| assert_array_equals(swapped, [4.2, 7]); | ||
| }, "multiple return values from js to wasm"); |
There was a problem hiding this comment.
I don't understand how this is JS to Wasm. Did you mean to make further changes to this test?
There was a problem hiding this comment.
It isn't, indeed. I removed this part; I'll submit a JS to wasm test at some later point.
Ms2ger
force-pushed
the
wasm-multi-value
branch
from
7ca158a
to
cddc97b
Compare
xtuc
reviewed
Nov 14, 2019
xtuc
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.