Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize GenerateAll to avoid doing unnecessary work #430

Open
whitequark opened this issue May 23, 2019 · 6 comments
Open

Optimize GenerateAll to avoid doing unnecessary work #430

whitequark opened this issue May 23, 2019 · 6 comments

Comments

@whitequark
Copy link
Contributor

  • It's not necessary to regenerate each entity when doing something simple like dragging a point in the very last group: Evil-Spirit@a5ffd9d
  • It's not necessary to move actual entities (large) in IdList; it is possible to add a level of indirection so that only indexes (small) move: Evil-Spirit@9cf1a09
@Evil-Spirit
Copy link
Collaborator

Evil-Spirit commented Jun 14, 2019

I actually don't know because of which commit, but my branch https://github.com/Evil-Spirit/solvespace-master/tree/user-param-proto very fast in comparsion with 2.3. Now I am drawing my brand-new house
SolveSpace - F__Dropbox_SolveSpace_house_kladka slvs 2019-06-14 11 13 03
20190613_101551

@whitequark
Copy link
Contributor Author

Very nice. Congratulations on the house :D

@Evil-Spirit
Copy link
Collaborator

Evil-Spirit commented Jun 14, 2019

Drawing houses in reality isn't the same thing as drawing in SolveSpace ;)

@Evil-Spirit
Copy link
Collaborator

Sorry for spaming:
SolveSpace - F__Dropbox_SolveSpace_house_stairs_house slvs 2020-05-13 12 02 49

SolveSpace - F__Dropbox_SolveSpace_house_stairs_house slvs 2020-05-13 12 01 53

SolveSpace - F__Dropbox_SolveSpace_house_roof_actual slvs 2020-05-13 12 18 56

image

@ruevs
Copy link
Member

ruevs commented May 13, 2020

Offtopic: Watched your video with the laser level - impressive precision - beautiful!

@whitequark
Copy link
Contributor Author

@Evil-Spirit That looks really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants