Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rPackages.git2r: Use system libgit2 #63129

Merged
merged 1 commit into from Jun 14, 2019
Merged

rPackages.git2r: Use system libgit2 #63129

merged 1 commit into from Jun 14, 2019

Conversation

jabranham
Copy link
Contributor

Otherwise git2r builds a bundled libgit2

Motivation for this change

Use the system's libgit2, where a binary substitution is usually available, instead of building one from source.

Thanks to manveru on IRC for finding that pkgconfig is also needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Otherwise git2r builds a bundled libgit2
@jabranham jabranham requested a review from peti as a code owner June 14, 2019 15:08
@peti peti merged commit d9d29d9 into NixOS:master Jun 14, 2019
@jabranham jabranham deleted the r-git2r branch June 14, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants