zabbix: adding zabbix proxy support #63130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build zabbix zabbix20 zabbix34 zabbix22 Can you maybe write a test for the module? |
|
@andir not a bad idea at all, the service is fairly simple. Added the test. |
aanderse
requested changes
Jun 15, 2019
- not running the proxy under root - logrotate - adding more database configuration options - adding support for password file
|
@GrahamcOfBorg eval |
|
I was looking into the configuration on the zabbix site and realized that most the versions we ship are badly out of date and unsupported upstream. We shouldn't be shipping software that isn't supported upstream. |
|
You are right. I plan to do a major upgrade and switch to 3.4 as a default.
But that is a major non compatible change that will have to go to release
notes.
But that is for another pull request :) (I hope to start working on it in about two weeks).
|
|
Implemented in #63844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding zabbix proxy support by creating a new zabbix proxy module along with zabbix-proxy subpackages.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)