Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 60.7.0 -> 60.7.1 [High security fixes] #63131

Merged
merged 2 commits into from
Jun 15, 2019
Merged

thunderbird, thunderbird-bin: 60.7.0 -> 60.7.1 [High security fixes] #63131

merged 2 commits into from
Jun 15, 2019
+235 −235

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jun 14, 2019

Motivation for this change
  • High security fixes
  • Other bug fix

https://www.thunderbird.net/en-US/thunderbird/60.7.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2019-17/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested review from nbp and edolstra June 14, 2019 15:47
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 14, 2019
vcunat
vcunat approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both run fine for me.

pull bot pushed a commit to evanjs/nixpkgs that referenced this pull request Jun 15, 2019
@vcunat
Merge NixOS#63131: thunderbird*: 60.7.0 -> 60.7.1 (security)
5480234
@vcunat vcunat merged commit 6055f89 into NixOS:master Jun 15, 2019
vcunat added a commit that referenced this pull request Jun 16, 2019
@vcunat
Merge #63131: thunderbird*: 60.7.0 -> 60.7.1 (security)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8992980 
(cherry picked from commit 5480234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

@nbp nbp

@edolstra edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taku0 @vcunat