MSE: Let external/wpt/.../mediasource-play have longer timeout #17322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 13, 2019
This test normally takes only 1-2 seconds to execute on Chromium Mac release builders, but can timeout at low frequency (3 times in > 100 builds). Per WPT documentation [1], this change marks the test timeout as "long". In Blink, this change also removes the flaky timeout test expectation for this test. [1] https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout BUG=971252 TEST=confirmed locally with Blink's web test runner and injected test delays that this change allows the test to run over 6 seconds without failing with timeout. Change-Id: Icf60260640f201f3fc3c072c6bef9097bff928df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659132 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#669043}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1659132
branch
from
94c014f
to
0e5cc04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test normally takes only 1-2 seconds to execute on Chromium Mac
release builders, but can timeout at low frequency (3 times in > 100
builds). Per WPT documentation [1], this change marks the test timeout
as "long". In Blink, this change also removes the flaky timeout test
expectation for this test.
[1]
https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout
BUG=971252
TEST=confirmed locally with Blink's web test runner and injected test
delays that this change allows the test to run over 6 seconds without
failing with timeout.
Change-Id: Icf60260640f201f3fc3c072c6bef9097bff928df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659132
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669043}