[Gecko Bug 1557548] part1 : remove 'controls' attribute from video. #17321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's no need to add 'controls' attribute in this test because it's totally unrelated with navigation and we even have to add extra offset for the cue text in the reference file. Differential Revision: https://phabricator.services.mozilla.com/D34777 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1557548 gecko-commit: cd473827dfd4ecf8d33f26d1764e5d51ebf2c393 gecko-integration-branch: autoland gecko-reviewers: heycam
wpt-pr-bot
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no need to add 'controls' attribute in this test because it's totally unrelated with navigation and we even have to add extra offset for the cue text in the reference file.
Differential Revision: https://phabricator.services.mozilla.com/D34777
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1557548
gecko-commit: cd473827dfd4ecf8d33f26d1764e5d51ebf2c393
gecko-integration-branch: autoland
gecko-reviewers: heycam