New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: 1.34.2 -> 1.35.0 #63099
rustc: 1.34.2 -> 1.35.0 #63099
Conversation
|
macOS seems to have a build problem: https://logs.nix.ci/?key=nixos/nixpkgs.63099&attempt_id=6794ed4e-fcbd-4308-9fe9-458a9a87bc95
|
This doesn't work anymore since 1.35.0 because the load commands end up being too large, but this is a precompiled binary anyway so it's not really needed or more impure to use the expected system versions.
@@ -85,7 +75,8 @@ rec { | |||
license = [ licenses.mit licenses.asl20 ]; | |||
}; | |||
|
|||
buildInputs = [ makeWrapper bash ] ++ stdenv.lib.optional stdenv.isDarwin Security; | |||
buildInputs = [ makeWrapper bash ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mic92 do you remember why you added bash here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LnL7 also looks suspicious to me. It would only make a difference in a cross-compiled build. We can properly drop it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If macOS builds, we can merge this!
Yep, has anyboy tested firefox? |
I was able to build firefox. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)