Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: Make steam optional #64995

Closed
wants to merge 1 commit into from
Closed

lutris: Make steam optional #64995

wants to merge 1 commit into from

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

I want to play MTG Arena, but not with unfree shit on my devices.

Thus this is an ongoing effort to make lutris free of any unfree stuff, bit by bit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Help welcome!

@matthiasbeyer
lutris: Make steam optional
50f73e6 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
worldofpeace
worldofpeace reviewed Jul 17, 2019
View reviewed changes
pkgs/applications/misc/lutris/default.nix
@@ -107,7 +106,8 @@ let

# ZDOOM
soundfont-fluid bzip2 game-music-emu
] ++ qt5Deps
] ++ (if isNull steam then [] else [steam])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add a withSteam ? true and use ++ lib.optional withSteam steam.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a much better approach, yes!

@abbradar
Copy link
Member

abbradar commented Jul 18, 2019 •
edited

I did these changes coincidentally today without checking if there's an existing PR, sorry.

You can install lutris-free now to avoid Steam.

EDIT: For reference, commits which enable this:
b0a961e
48d98b0

@abbradar abbradar closed this Jul 18, 2019
@matthiasbeyer
Copy link
Contributor Author

@abbradar you are awesome, thank you!

@matthiasbeyer matthiasbeyer deleted the free-lutris branch July 18, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @abbradar @worldofpeace