Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ibis-framework: init at 1.2.0 #64996

Merged
merged 2 commits into from Jul 19, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

Adding ibis-framework for a project currently working on

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner July 17, 2019 18:37
@costrouc
Copy link
Member Author

Result of nix-review pr 64996 1

2 package were build:
  • python37Packages.ibis
  • python37Packages.ibis-framework

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.ibis-framework python3Packages.ibis

@costrouc costrouc changed the title python3Packages.ibis-framework: init python3Packages.ibis-framework: init at 1.2.0 Jul 17, 2019
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.ibis-framework python3Packages.ibis

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
Diff LGTM
leaf packages

nice :)

@risicle
Copy link
Contributor

risicle commented Jul 18, 2019

nox-review is happy for me non-nixos linux x86_64

@FRidh FRidh merged commit 2d57698 into NixOS:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants