Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.monkeyhex: init at 1.7.1 #64998

Merged
merged 1 commit into from Nov 14, 2019
Merged

pythonPackages.monkeyhex: init at 1.7.1 #64998

merged 1 commit into from Nov 14, 2019

Conversation

Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Jul 17, 2019 •
edited

Motivation for this change

Make the monkeyhex package available on NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Pamplemousse Pamplemousse requested a review from FRidh as a code owner July 17, 2019 18:39
jonringer
jonringer reviewed Jul 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also switch the position of src and propagatedBuildInputs.

I prefer this because src is usually fixed in size, if you were to have more dependencies such https://github.com/NixOS/nixpkgs/pull/64996/files then it's nice to have that farther down. Idk, really just a consistency thing :)

pkgs/development/python-modules/monkeyhex/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/monkeyhex/default.nix Outdated Show resolved Hide resolved
@Pamplemousse Pamplemousse force-pushed the monkeyhex branch 2 times, most recently from 2c53f06 to 3a6f961 Compare July 17, 2019 21:08
@Pamplemousse
Copy link
Member Author

@jonringer: Thanks for your feedback!

jonringer
jonringer approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

@smaret
Copy link
Member

smaret commented Jul 18, 2019

PR built sucessfully on Darwin nix-review pr.

@risicle
Copy link
Contributor

risicle commented Jul 19, 2019

nox-review is happy on macos 10.13

@smaret
Copy link
Member

smaret commented Jul 25, 2019

@Pamplemousse Can you please fix the conflict?

@Pamplemousse
Copy link
Member Author

Poke @FRidh : is there anything blocking?
Cheers :)

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
repo looks a little on the... lonely side, but alright

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64998
3 package were build:
python27Packages.monkeyhex python37Packages.monkeyhex python38Packages.monkeyhex

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.monkeyhex python37Packages.monkeyhex python38Packages.monkeyhex

@jonringer jonringer merged commit 3caa0dc into NixOS:master Nov 14, 2019
@Pamplemousse Pamplemousse deleted the monkeyhex branch November 14, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaret smaret smaret approved these changes

@kira-bruneau kira-bruneau kira-bruneau approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Pamplemousse @smaret @risicle @jonringer @kira-bruneau @lheckemann