Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.filebytes: 0.9.20 -> 0.9.21 #64954

Merged
merged 1 commit into from Jul 17, 2019
Merged

pythonPackages.filebytes: 0.9.20 -> 0.9.21 #64954

merged 1 commit into from Jul 17, 2019

Conversation

Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Jul 16, 2019 •
edited

Motivation for this change

Relates to #64930 : solves the failing nix-build -A python27Packages.ropper, as filebytes is one of its dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review pr 64931"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Pamplemousse Pamplemousse requested a review from FRidh as a code owner July 16, 2019 23:03
@Pamplemousse
Copy link
Member Author

CC @bennofs .

@ofborg ofborg bot requested a review from bennofs July 16, 2019 23:17
@marsam marsam merged commit 8e94a72 into NixOS:master Jul 17, 2019
@marsam
Copy link
Contributor

marsam commented Jul 17, 2019

Thanks!

@marsam marsam mentioned this pull request Jul 17, 2019
Closed
@Pamplemousse Pamplemousse deleted the filebytes branch July 18, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pamplemousse @marsam